Skip to content

Comments

Migrate tsan config_setting to new unified constraint.#16528

Closed
akrieger wants to merge 2 commits intopytorch:mainfrom
akrieger:export-D88306709
Closed

Migrate tsan config_setting to new unified constraint.#16528
akrieger wants to merge 2 commits intopytorch:mainfrom
akrieger:export-D88306709

Conversation

@akrieger
Copy link
Contributor

@akrieger akrieger commented Jan 9, 2026

Summary: WTTS. Just sed. And then delete the old one.

Reviewed By: rexzhang123

Differential Revision: D88306709

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 9, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16528

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 0d8430a with merge base 7436438 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-codesync
Copy link
Contributor

meta-codesync bot commented Jan 9, 2026

@akrieger has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88306709.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2026
8Keep
8Keep approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@8Keep 8Keep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

akrieger added a commit to akrieger/executorch that referenced this pull request Jan 9, 2026
@akrieger @facebook-github-bot
Migrate tsan config_setting to new unified constraint. (pytorch#16528)
5cb21f2 
Summary:

WTTS. Just sed. And then delete the old one.

Reviewed By: rexzhang123

Differential Revision: D88306709
@akrieger
Copy link
Contributor Author

akrieger commented Jan 12, 2026

I think this is superseded by #16529.

akrieger added a commit to akrieger/executorch that referenced this pull request Jan 12, 2026
@akrieger @facebook-github-bot
Migrate tsan config_setting to new unified constraint. (pytorch#16528)
1552b44 
Summary:

WTTS. Just sed. And then delete the old one.

Reviewed By: rexzhang123

Differential Revision: D88306709
akrieger added a commit to akrieger/executorch that referenced this pull request Jan 12, 2026
@akrieger @facebook-github-bot
Migrate tsan config_setting to new unified constraint. (pytorch#16528)
c1907b4 
Summary:

WTTS. Just sed. And then delete the old one.

Reviewed By: rexzhang123

Differential Revision: D88306709
@akrieger @facebook-github-bot
Migrate asan config_setting to new unified constraint.
f897508 
Summary: WTTS. Just sed. And then delete the old one.

Reviewed By: aforster

Differential Revision: D88306710
@akrieger @facebook-github-bot
Migrate tsan config_setting to new unified constraint. (pytorch#16528)
0d8430a 
Summary:

WTTS. Just sed. And then delete the old one.

Reviewed By: rexzhang123

Differential Revision: D88306709
@akrieger akrieger closed this Jan 13, 2026
@akrieger akrieger deleted the export-D88306709 branch January 13, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@8Keep 8Keep 8Keep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akrieger @8Keep